cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320858231
##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+ String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
Well JIRA currently states following:
>transfer message are currently hard to read for many users
> (logging example cut for brevity)
> * it's interweaved into normal build messages
> * users don't really see the difference between "Downloading" (transfert
started, may eventually fail with 404) and "Downloaded" (done successfully)
> * repository id is not so visible in the middle of the message
> * the download url has much info in it to see: base url, groupId as
directory, artifactId, version, and filename
So, based on this above, I assumed, that: is interweave and too chatty, so
cut it down, and if "users don't see the difference", they are right: As I
said, this logger when 5 repositories are defined will emit 5 "Downloading" and
1 "Downloaded", and the one "Downloaded" matters, the 5 "Downloading" does not
(better check with effective-pom what reposes you have instead to repeat it to
each artifact you need to download).
Unsure how JIRA comes to conclusion based on these 4 bullets above "ok,
let's color it!", when it is ONLY solving the last bullet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
