cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320862296


##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
 
     @Override
     public void transferInitiated(TransferEvent event) {
+        String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";

Review Comment:
   As we know, by default Maven "leaks" your artifact paths, and **only 
reason** "Downloading" log line is useful is only this one: it makes user 
**aware** Maven is making HTTP request against the logged baseUrl. OTOH, due 
overwhelming amount of Maven logging, this information is usually lost, due 
log-noise.
   
   To properly fix "leaking", use 
[RRF](https://maven.apache.org/resolver/remote-repository-filtering.html) but 
that is another thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to