[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763485#comment-17763485
]
ASF GitHub Bot commented on MNG-7875:
-------------------------------------
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320862296
##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+ String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
As we know, by default Maven "leaks" your artifact paths, and **only
reason** "Downloading" log line is useful is only this one: it makes user
**aware** Maven is making HTTP request against the logged baseUrl. OTOH, due
overwhelming amount of Maven logging, this information is usually lost, due
log-noise.
To properly fix "leaking", use
[RRF](https://maven.apache.org/resolver/remote-repository-filtering.html) but
that is another thing.
> colorize transfer messages
> --------------------------
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
> Affects Versions: 3.9.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
