[ 
https://issues.apache.org/jira/browse/MINSTALL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788347#comment-17788347
 ] 

ASF GitHub Bot commented on MINSTALL-195:
-----------------------------------------

apeteri opened a new pull request, #59:
URL: https://github.com/apache/maven-install-plugin/pull/59

   A follow-up PR mirroring the changes suggested in 
apache/maven-deploy-plugin#45 to `InstallMojo`.
   
   --
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MINSTALL) filed for the change 
(usually before you start working on it).  Trivial changes like typos do not 
require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[MINSTALL-XXX] - Fixes bug in 
ApproximateQuantiles`, where you replace `MINSTALL-XXX` with the appropriate 
JIRA issue. Best practice is to use the JIRA issue title in the pull request 
title and in the first line of the commit message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an 
[Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please 
ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have 
to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Include artifactId in messages of InstallMojo#processProject
> ------------------------------------------------------------
>
>                 Key: MINSTALL-195
>                 URL: https://issues.apache.org/jira/browse/MINSTALL-195
>             Project: Maven Install Plugin
>          Issue Type: Improvement
>          Components: install:install
>    Affects Versions: 3.1.1
>            Reporter: András Péteri
>            Priority: Major
>
> A companion request for MDEPLOY-314: if an issue is encountered in "install 
> at end" mode in the method mentioned in the title, the {{project}} method 
> argument's artifact ID should be mentioned as it might not be the same as the 
> {{project}} parameter on the class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to