[ 
https://issues.apache.org/jira/browse/MINSTALL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788348#comment-17788348
 ] 

ASF GitHub Bot commented on MINSTALL-195:
-----------------------------------------

apeteri commented on code in PR #59:
URL: 
https://github.com/apache/maven-install-plugin/pull/59#discussion_r1400294012


##########
src/it/no-main-artifact-1/verify.groovy:
##########
@@ -19,5 +19,5 @@
 
 def buildLog = new File ( basedir, "build.log")
 
-assert buildLog.text.contains( "The packaging plugin for this project did not 
assign "
+assert buildLog.text.contains( "The packaging plugin for project test did not 
assign "

Review Comment:
   There are two similar IT cases in m-d-p that break once this change is 
applied, as they actually test the output of this plugin. Should I modify the 
assertion there as well?





> Include artifactId in messages of InstallMojo#processProject
> ------------------------------------------------------------
>
>                 Key: MINSTALL-195
>                 URL: https://issues.apache.org/jira/browse/MINSTALL-195
>             Project: Maven Install Plugin
>          Issue Type: Improvement
>          Components: install:install
>    Affects Versions: 3.1.1
>            Reporter: András Péteri
>            Priority: Major
>
> A companion request for MDEPLOY-314: if an issue is encountered in "install 
> at end" mode in the method mentioned in the title, the {{project}} method 
> argument's artifact ID should be mentioned as it might not be the same as the 
> {{project}} parameter on the class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to