schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1420602906
##########
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##########
@@ -251,78 +250,80 @@ public abstract class AbstractJarsignerMojo extends
AbstractMojo {
@Component(hint = "mng-4384")
private SecDispatcher securityDispatcher;
+ @Override
public final void execute() throws MojoExecutionException {
- if (!this.skip) {
- Toolchain toolchain = getToolchain();
+ if (this.skip) {
+ getLog().info(getMessage("disabled"));
+ return;
+ }
Review Comment:
I did an indentation change for this method that my IDE showed nicely, but
GitHub diff goes bananas over it. I could change it back. However in the scope
of https://issues.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-72 I
still plan to refactor this method. I'm not sure if MJARSIGNER-72 will be
accepted by the community, but I will still implement it because I have a
direct need for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
