schedin commented on code in PR #13:
URL: 
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421717905


##########
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##########
@@ -90,6 +94,30 @@ public class JarsignerSignMojo extends AbstractJarsignerMojo 
{
     @Parameter(property = "jarsigner.certchain", readonly = true, required = 
false)
     private File certchain;
 
+    /**
+     * How many times to try to sign a jar (assuming each previous attempt is 
a failure). This option may be desirable
+     * if any network operations are used during signing, for example using a 
Time Stamp Authority or network based
+     * PKCS11 HSM solution for storing code signing keys.
+     *
+     * The default value of 1 indicate that no retries should be made.
+     *
+     * @since 3.1.0
+     */
+    @Parameter(property = "jarsigner.maxTries", defaultValue = "1")
+    private int maxTries;
+
+    /**
+     * Maximum delay, in seconds, to wait after a failed attempt before 
re-trying. The delay after a failed attempt
+     * follows an exponential backoff strategy, with increasing delay times.
+     *
+     * @since 3.1.0
+     */
+    @Parameter(property = "jarsigner.maxRetryDelaySeconds", defaultValue = "0")
+    private int maxRetryDelaySeconds;

Review Comment:
   Fixed by the adding of `JarsignerSignMojo.validateParameters()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to