[ 
https://issues.apache.org/jira/browse/SUREFIRE-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796304#comment-17796304
 ] 

ASF GitHub Bot commented on SUREFIRE-2221:
------------------------------------------

sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425445430


##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
 +---+
 
          The above example assumes that your toolchains.xml contains a valid 
entry with these values.
+
+* Minimal Java Versoin for Toolchains

Review Comment:
   Sorry I copy/paste you text just above :point_up: 
https://github.com/apache/maven-surefire/pull/701#discussion_r1425396777, I 
will fix it.





> Document minimum supported Java version for Toolchains
> ------------------------------------------------------
>
>                 Key: SUREFIRE-2221
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2221
>             Project: Maven Surefire
>          Issue Type: Improvement
>    Affects Versions: 3.2.3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.2.4
>
>
> As it turns out, even if Toolchains is used with an older Java version the 
> base line is always  Java 8 since Surefire requires Java 8 as minimum. We 
> should document that since people are having a hard time with this, see 
> SUREFIRE-1923.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to