[
https://issues.apache.org/jira/browse/SUREFIRE-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796305#comment-17796305
]
ASF GitHub Bot commented on SUREFIRE-2221:
------------------------------------------
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425449591
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid
entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain
is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> ||
<<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 |
52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 |
51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 |
50 |
+*---------------------------------------------+---------------------------+-------------------------+
+
+ If you try to use an older version than minimal supported one, you should
face something like:
Review Comment:
You want me to change it like this :
```diff
-If you try to use an older version than minimal supported one
+If you try to use an older version then the minimal supported one
```
My english is not very good but I didn't get the sentence like this, so I
need some explanation ?
I tried to get help with deepl and it propose something like :
> If you try to use a version older than the minimum supported version
Does it sounds better ?
> Document minimum supported Java version for Toolchains
> ------------------------------------------------------
>
> Key: SUREFIRE-2221
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2221
> Project: Maven Surefire
> Issue Type: Improvement
> Affects Versions: 3.2.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.2.4
>
>
> As it turns out, even if Toolchains is used with an older Java version the
> base line is always Java 8 since Surefire requires Java 8 as minimum. We
> should document that since people are having a hard time with this, see
> SUREFIRE-1923.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
