[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799088#comment-17799088 ]
ASF GitHub Bot commented on MARCHETYPES-76: ------------------------------------------- judovana commented on code in PR #18: URL: https://github.com/apache/maven-archetypes/pull/18#discussion_r1432919700 ########## maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml: ########## @@ -1,11 +1,11 @@ <?xml version="1.0" encoding="UTF-8"?> -#macro( compilerProperties $javaCompilerVersion ) +#macro( compilerProperties $jcv ) Review Comment: There was the name clash between global and local "variable". I wanted to make clear, that it is obvious on first glance, what is local to macro, and what is global one. See https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L2 compare with full: https://github.com/judovana/maven-archetypes/blob/defaultJdk8/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L48 > maven-archetype-quickstart generates EOLed maven.compiler setup > ---------------------------------------------------------------- > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Reporter: jiri vanek > Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)