[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800930#comment-17800930
]
ASF GitHub Bot commented on MPLUGIN-495:
----------------------------------------
slawekjaranowski commented on code in PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#discussion_r1437444720
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java:
##########
@@ -781,22 +780,8 @@ private List<MojoDescriptor> toMojoDescriptors(
parameter.setName(componentAnnotationContent.getFieldName());
// recognize Maven-injected objects as components annotations
instead of parameters
Review Comment:
comment is not true now
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -----------------------------------------------------------------------------------------
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Affects Versions: 3.10.2
> Reporter: Karl Heinz Marbaise
> Assignee: Michael Osipov
> Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
