[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801041#comment-17801041
]
ASF GitHub Bot commented on MPLUGIN-495:
----------------------------------------
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871431696
I jave just tried a snapshot against Maven Dependency Plugin as @khmarbaise
has reported. I get:
```
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
TestCollectMojo.testCollectTestEnvironment:44->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.project.MavenProject, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.execution.scope.internal.MojoExecutionScopeCoreModule)
while locating org.apache.maven.project.MavenProject
while locating
org.apache.maven.plugins.dependency.resolvers.CollectDependenciesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect
[ERROR]
TestCollectMojo.testCollectTestEnvironment_excludeTransitive:71->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.project.MavenProject, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.execution.scope.internal.MojoExecutionScopeCoreModule)
while locating org.apache.maven.project.MavenProject
while locating
org.apache.maven.plugins.dependency.resolvers.CollectDependenciesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect
[ERROR]
TestCollectMojo.testSilent:95->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.project.MavenProject, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.execution.scope.internal.MojoExecutionScopeCoreModule)
while locating org.apache.maven.project.MavenProject
while locating
org.apache.maven.plugins.dependency.resolvers.CollectDependenciesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:collect
[ERROR]
TestGetMojo.setUp:54->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.GetMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get
[ERROR]
TestGetMojo.setUp:54->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.GetMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get
[ERROR]
TestGetMojo.setUp:54->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.GetMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get
[ERROR]
TestGetMojo.setUp:54->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.GetMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:get
[ERROR]
TestListClassesMojo.setUp:45->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.ListClassesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes
[ERROR]
TestListClassesMojo.setUp:45->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.ListClassesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes
[ERROR]
TestListClassesMojo.setUp:45->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:410->PlexusTestCase.lookup:205
� ComponentLookup com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
outside of a scoping block
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule
-> org.apache.maven.session.scope.internal.SessionScopeModule)
while locating org.apache.maven.execution.MavenSession
while locating org.apache.maven.plugins.dependency.ListClassesMojo
at ClassRealm[plexus.core, parent: null] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes)
1 error
role: org.apache.maven.plugin.Mojo
roleHint:
org.apache.maven.plugins:maven-dependency-plugin:3.6.2-SNAPSHOT:list-classes
```
I guess something is missing on the test classpath, but I have no idea
what...
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -----------------------------------------------------------------------------------------
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Affects Versions: 3.10.2
> Reporter: Karl Heinz Marbaise
> Assignee: Michael Osipov
> Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
