[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803926#comment-17803926
]
ASF GitHub Bot commented on DOXIASITETOOLS-324:
-----------------------------------------------
kwin commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443971657
##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfiguration.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.siterenderer;
+
+import java.util.function.Consumer;
+
+import org.apache.maven.doxia.parser.Parser;
+
+/**
+ * Configures a Doxia {@link Parser}.
+ * @since 2.0.0
+ */
+@FunctionalInterface
+public interface ParserConfiguration extends Consumer<Parser> {
+
+ /**
+ * Applies the configuration to the given parser.
+ * @param parser the parser to configure
+ */
+ @Override
+ void accept(Parser parser);
Review Comment:
Right, I was thinking about implementing a default Java interface (Consumer)
but method name `accept` is really weird in this context and converting between
different functional interfaces is easy enough with lambdas.
> Allow configuration of parser (per markup source path pattern)
> --------------------------------------------------------------
>
> Key: DOXIASITETOOLS-324
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324
> Project: Maven Doxia Sitetools
> Issue Type: New Feature
> Components: Site renderer
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 2.0.0-M17
>
>
> Currently the Doxia parsers being used for the Doxia markup sources have a
> fix configuration
> (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324).
> It would be beneficial to allow to dynamically configure the parsers (based
> on a matching markup source path pattern)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
