rnveach commented on code in PR #141:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1630515144
##########
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java:
##########
@@ -26,22 +26,24 @@
import java.io.OutputStream;
import java.nio.file.Path;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import java.util.Locale;
import java.util.Map;
+import
com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions;
Review Comment:
@michael-o So basically you need us to add a ctor to `SarifLogger` which
supports `AutomaticBean.OutputStreamOptions` as the 2nd parameter, and keep
`OutputStream` as the first parameter?
I won't say that can't be done, but if you look at the source of these type
of ctors, you will see we use some pretty simple code to convert
`AutomaticBean.OutputStreamOptions` to
`AbstractAutomaticBean.OutputStreamOptions`.
````
public XMLLogger(OutputStream outputStream,
AutomaticBean.OutputStreamOptions outputStreamOptions) {
this(outputStream,
OutputStreamOptions.valueOf(outputStreamOptions.name()));
}
````
You could simply call
`OutputStreamOptions.valueOf(outputStreamOptions.name())` to convert the
deprecated options to the new options and not rely on us for anything. This
would also allow the maven plugin to be backwards compatible for more CS
versions as anything new we add will only be available in the next release.
To be honest, we want to remove these deprecated stuff, but we have been
stuck waiting on the maven plugin to update. It really wouldn't make sense to
us to add more deprecated stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
