cstamas commented on code in PR #11970:
URL: https://github.com/apache/maven/pull/11970#discussion_r3119350939
##########
maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycles.java:
##########
@@ -46,7 +50,18 @@
@Singleton
@Named
public class DefaultLifecycles {
- public static final String[] STANDARD_LIFECYCLES = {"clean", "default",
"site"};
+ private static final List<String> BUILT_IN_LIFECYCLES =
+ Arrays.asList(CleanLifecycleProvider.NAME,
DefaultLifecycleProvider.NAME, SiteLifecycleProvider.NAME);
+ private static final boolean SITE_ENABLED =
+
Boolean.parseBoolean(System.getProperty("maven.site.lifecycle.enabled",
"true"));
Review Comment:
Looked around, and in many places session is not present/passed over. While
we could alter these classes, that would lead to many potential breakages.
I consider this use case "special" or "very edge", so IMO Java System
property is good to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
