michael-o commented on code in PR #11970:
URL: https://github.com/apache/maven/pull/11970#discussion_r3119678000
##########
maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycles.java:
##########
@@ -46,7 +50,18 @@
@Singleton
@Named
public class DefaultLifecycles {
- public static final String[] STANDARD_LIFECYCLES = {"clean", "default",
"site"};
+ private static final List<String> BUILT_IN_LIFECYCLES =
+ Arrays.asList(CleanLifecycleProvider.NAME,
DefaultLifecycleProvider.NAME, SiteLifecycleProvider.NAME);
+ private static final boolean SITE_ENABLED =
+
Boolean.parseBoolean(System.getProperty("maven.site.lifecycle.enabled",
"true"));
Review Comment:
Indeed, you can't, but maybe we should invert the logic anyway? Site
lifecycle is always enabled unless you explicitly disable this, e.g.,
`-DskipTests=true` and other skippers. `-Dmaven.site.lifecycle.skip`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
