Copilot commented on code in PR #1097: URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3675302675
########## src/it/multirelease-patterns/singleproject-toolchains/invoker.properties: ########## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. invoker.goals = verify -Pmulti-jar -invoker.toolchain.jdk.version=1.9 +invoker.toolchain.jdk.version=1.8 Review Comment: This IT lives under `multirelease-patterns`, where building/verifying multi-release JAR behavior typically requires JDK 9+ (multi-release JAR support was introduced in Java 9). Changing the invoker toolchain from `1.9` to `1.8` is likely to either break the test or make it exercise the wrong behavior. Consider keeping it at a 9+ toolchain (e.g., `9` / `1.9`) unless the test is explicitly intended to run on JDK 8 only, in which case the test directory/name/profile should be adjusted to reflect that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
