desruisseaux commented on code in PR #1097: URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3675601772
########## src/it/multirelease-patterns/singleproject-toolchains/invoker.properties: ########## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. invoker.goals = verify -Pmulti-jar -invoker.toolchain.jdk.version=1.9 +invoker.toolchain.jdk.version=1.8 Review Comment: Ok, I removed the `invoker.toolchain.jdk.version` change. I verified that no matter if we set the Java version to 8 ot 9, the test is skipped anyway, both locally on my machine and in GitHub action. As it stands today, the `it/multirelease-patterns/singleproject-toolchains` test is useless and should be either removed or changed into something which is actually executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
