goutamadwant opened a new pull request, #13118:
URL: https://github.com/apache/maven/pull/13118
Adds a `SettingsParser` SPI so extensions can read another settings syntax
without replacing `DefaultSettingsBuilder`. XML remains the fallback. Each
source selects one parser, strict failures retry that parser leniently, and
conflicting providers produce a diagnostic.
Interpolation, decryption, validation, project-settings restrictions, and
merging remain in the existing builder. The SPI accepts file-backed and
in-memory sources. No YAML dependency is added.
Settings discovery and extension loading are unchanged. A parser must
already be available to the container reading settings; an extension cannot
parse the bootstrap settings needed to resolve itself. Integration tests cover
extension-classpath parsing, XML fallback, the bootstrap limitation, and a
parser available in the core realm.
Validation:
- 17 parser unit tests and 3 CLI integration tests passed on Java 21.
- `mvn -B -ntp -Prun-its -Dits.forkCount=4 verify` passed on Java 17: all 90
modules, 3,193 unit tests and 1,077 Core IT cases, zero failures/errors (16
unit and 44 Core IT skips).
- Final focused Java 17 rerun passed all 23 tests after a test-fixture
portability correction.
Closes #10436.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
