gnodet-bot commented on code in PR #13118:
URL: https://github.com/apache/maven/pull/13118#discussion_r4011028457
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java:
##########
@@ -159,35 +167,24 @@ private Settings readSettings(
Settings settings;
try {
- try (InputStream is = settingsSource.openStream()) {
- settings = settingsXmlFactory.read(XmlReaderRequest.builder()
- .inputStream(is)
- .location(settingsSource.getLocation())
- .strict(true)
- .build());
- } catch (XmlReaderException e) {
- try (InputStream is = settingsSource.openStream()) {
- settings =
settingsXmlFactory.read(XmlReaderRequest.builder()
- .inputStream(is)
- .location(settingsSource.getLocation())
- .strict(false)
- .build());
- Location loc = e.getCause() instanceof XMLStreamException
xe ? xe.getLocation() : null;
- problems.reportProblem(new DefaultBuilderProblem(
- settingsSource.getLocation(),
- loc != null ? loc.getLineNumber() : -1,
- loc != null ? loc.getColumnNumber() : -1,
- e,
- e.getMessage(),
- BuilderProblem.Severity.WARNING));
- }
+ SettingsParser parser = selectParser(settingsSource);
+ try {
+ settings = parser.parse(settingsSource,
Map.of(SettingsParser.STRICT, true));
+ } catch (SettingsParserException e) {
+ settings = parser.parse(settingsSource,
Map.of(SettingsParser.STRICT, false));
+ problems.reportProblem(new DefaultBuilderProblem(
+ settingsSource.getLocation(),
+ e.getLineNumber(),
+ e.getColumnNumber(),
+ e,
+ e.getMessage(),
+ BuilderProblem.Severity.WARNING));
Review Comment:
test retry comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
