goutamadwant commented on code in PR #13118:
URL: https://github.com/apache/maven/pull/13118#discussion_r4012928329
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java:
##########
@@ -245,6 +245,30 @@ private Server serverAlias(Server server, String id) {
return Server.newBuilder(server,
true).id(id).aliases(List.of()).build();
}
+ @Nullable
+ private SettingsParser selectParser(Source source,
ProblemCollector<BuilderProblem> problems) {
+ List<Map.Entry<String, SettingsParser>> matches =
settingsParsers.entrySet().stream()
+ .filter(entry -> entry.getValue().supports(source))
Review Comment:
Fixed. Runtime exceptions from supports() now produce a fatal
settings-builder problem identifying the provider and source, with the original
exception retained. Selection stops immediately for that source, preventing
further provider checks, parsing, or XML fallback. Added named and unnamed
provider regressions, including failure after an earlier match, and documented
the behavior. Full mvn -Prun-its verify passed on Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
