gnodet commented on code in PR #13137: URL: https://github.com/apache/maven/pull/13137#discussion_r4014814519
########## impl/maven-core/src/main/java/org/apache/maven/lifecycle/PluginVersions.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.lifecycle; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Properties; + +/** + * Provides default plugin versions for the built-in lifecycle bindings. + * <p> + * Versions are read from {@code plugin-versions.properties}, which is filtered + * at build time from POM properties ({@code version.maven-<name>-plugin}). + * Centralising them in the POM makes them visible to dependency-update bots + * such as Dependabot and Renovate. + * + * @since 4.1.0 Review Comment: Fixed in 2eaa501ad0: changed to `@since 4.0.0`. ########## impl/maven-core/src/main/java/org/apache/maven/lifecycle/PluginVersions.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.lifecycle; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Properties; + +/** + * Provides default plugin versions for the built-in lifecycle bindings. + * <p> + * Versions are read from {@code plugin-versions.properties}, which is filtered + * at build time from POM properties ({@code version.maven-<name>-plugin}). + * Centralising them in the POM makes them visible to dependency-update bots + * such as Dependabot and Renovate. + * + * @since 4.1.0 Review Comment: Fixed in 2eaa501ad0: changed to `@since 4.0.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
