gnodet commented on code in PR #13137:
URL: https://github.com/apache/maven/pull/13137#discussion_r4014816303
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java:
##########
@@ -35,29 +36,51 @@
*/
public abstract class AbstractLifecycleMappingProvider implements
Provider<LifecycleMapping> {
// START SNIPPET: versions
- protected static final String RESOURCES_PLUGIN_VERSION = "3.3.1";
+ /** @deprecated Use {@link PluginVersions#RESOURCES} instead. */
+ @Deprecated(since = "4.1.0", forRemoval = true)
Review Comment:
Fixed in 2eaa501ad0: removed all deprecated `*_PLUGIN_VERSION` constants
from `AbstractLifecycleMappingProvider` and migrated all 8 subclasses (Bom,
Ear, Ejb, Jar, MavenPlugin, Pom, Rar, War) to reference `PluginVersions.*`
directly. Since these constants never existed on `maven-4.0.x` prior to this
PR, there is no backward compatibility concern.
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java:
##########
@@ -35,29 +36,51 @@
*/
public abstract class AbstractLifecycleMappingProvider implements
Provider<LifecycleMapping> {
// START SNIPPET: versions
- protected static final String RESOURCES_PLUGIN_VERSION = "3.3.1";
+ /** @deprecated Use {@link PluginVersions#RESOURCES} instead. */
+ @Deprecated(since = "4.1.0", forRemoval = true)
Review Comment:
Fixed in 2eaa501ad0: the deprecated constants have been removed entirely
(see companion reply on the subclass migration comment). Since no external code
could reference these constants before this PR, there is no reason to keep a
deprecated bridge — the subclasses now use `PluginVersions.*` directly.
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java:
##########
@@ -35,29 +36,51 @@
*/
public abstract class AbstractLifecycleMappingProvider implements
Provider<LifecycleMapping> {
// START SNIPPET: versions
- protected static final String RESOURCES_PLUGIN_VERSION = "3.3.1";
+ /** @deprecated Use {@link PluginVersions#RESOURCES} instead. */
+ @Deprecated(since = "4.1.0", forRemoval = true)
Review Comment:
Fixed in 2eaa501ad0: all 8 subclasses migrated to `PluginVersions.*` and the
deprecated constants block removed from the abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
