gnodet commented on code in PR #1542:
URL: https://github.com/apache/maven/pull/1542#discussion_r4061205873
##########
maven-core/src/test/resources/projects/duplicate-plugins-merged-pom.xml:
##########
@@ -24,25 +25,36 @@
</execution>
</executions>
</plugin>
- <plugin>
- <artifactId>maven-compiler-plugin</artifactId>
- <dependencies>
- <dependency>
- <groupId>group</groupId>
- <artifactId>second</artifactId>
- <version>1</version>
- </dependency>
- </dependencies>
- <executions>
- <execution>
- <id>second</id>
- <goals>
- <goal>compile</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
+ </plugins>
</build>
+ <profiles>
+ <profile>
+ <id>foo</id>
+ <activation><activeByDefault>true</activeByDefault></activation>
Review Comment:
Fixed in 7f77651b649621fc28d9260536f0c2b38dcab992: replaced
`activeByDefault=true` with a property-based activation and updated the test to
explicitly activate the profile via `setActiveProfileIds(["foo"])`. This makes
the test immune to other profiles being activated in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
