gnodet-bot commented on code in PR #619:
URL: https://github.com/apache/maven-jar-plugin/pull/619#discussion_r4222565506
##########
pom.xml:
##########
@@ -193,13 +193,13 @@
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
- <excludes combine.children="append">
+ <inputExcludes>
<!--
! The manifest specification does not describe any method for
writing comments into the manifest.
-->
<exclude>src/it/mjar-71-01/src/main/resources/META-INF/MANIFEST.MF</exclude>
<exclude>src/it/mjar-71-02/src/main/resources/META-INF/MANIFEST.MF</exclude>
- </excludes>
+ </inputExcludes>
Review Comment:
⚠️ **Wrong child element name.** The inner `<exclude>` tags are still the
deprecated form and will continue to emit deprecation warnings. When switching
to `<inputExcludes>`, each child must be `<inputExclude>` (singular) — not
`<exclude>`.
Reference: `setInputExcludes(String[] inputExclude)` in
[BaseRatMojo](https://creadur.apache.org/rat/apache-rat-plugin/xref/org/apache/rat/plugin/BaseRatMojo.html)
— the parameter setter accepts `inputExclude` children. Every migrated Apache
project (Tika, Commons Collections, Commons Configuration) uses this form.
```suggestion
<inputExcludes>
<!--
! The manifest specification does not describe any method
for writing comments into the manifest.
-->
<inputExclude>src/it/mjar-71-01/src/main/resources/META-INF/MANIFEST.MF</inputExclude>
<inputExclude>src/it/mjar-71-02/src/main/resources/META-INF/MANIFEST.MF</inputExclude>
</inputExcludes>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
