gnodet commented on PR #609: URL: https://github.com/apache/maven-jar-plugin/pull/609#issuecomment-6061628097
@slawekjaranowski You're right on both counts — I verified this locally. Testing with `mvn help:effective-pom -Dverbose` both with and without `combine.children="append"` in the child POM produces identical effective POM output: all 12 entries (9 from `maven-parent:50` + 3 plugin-specific) are present in both cases. The attribute is inherited from the parent, so repeating it in the child is redundant. My initial review was wrong: 1. Dropping `combine.children` does **not** lose the parent's exclusions — the attribute is inherited as documented 2. The `combine.children` claim about other plugins was unverified Sorry for the noise. Feel free to revert commit `99b52e1` and go back to your original approach (no `combine.children` in the child POM) — that's correct and consistent with `apache/maven` itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
