gnodet commented on code in PR #619:
URL: https://github.com/apache/maven-jar-plugin/pull/619#discussion_r4225166449
##########
pom.xml:
##########
@@ -193,13 +193,13 @@
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
- <excludes combine.children="append">
+ <inputExcludes>
<!--
! The manifest specification does not describe any method for
writing comments into the manifest.
-->
<exclude>src/it/mjar-71-01/src/main/resources/META-INF/MANIFEST.MF</exclude>
<exclude>src/it/mjar-71-02/src/main/resources/META-INF/MANIFEST.MF</exclude>
- </excludes>
+ </inputExcludes>
Review Comment:
@slawekjaranowski You're right, I apologize for the noise. I looked at the
source more carefully:
`BaseRatMojo.setInputExcludes(String[] inputExclude)` is a setter-based
parameter — Maven/Plexus injects child elements as array entries regardless of
their tag name. The child element name is irrelevant for array parameters.
Using `<exclude>` inside `<inputExcludes>` works correctly and does not trigger
any deprecation path — the deprecated setter is `setExcludes(String[])` (bound
to `<excludes>`), not the child names.
Your build output confirms it: no deprecation warnings, no issues. The bot
was wrong on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
