desruisseaux commented on PR #618: URL: https://github.com/apache/maven-jar-plugin/pull/618#issuecomment-6079846930
I suggest to start with option **A** with amendments: Make the new classes package-private, so that they cannot be used outside the Maven JAR plugin (no committed API). Then simplify this pull requests by removing all getters/setters in `ArchiveConfiguration`. If that class is package-private, it is okay to read/write the fields directly because we don't need to protect anyone against potentially incompatible evolution of implementation details. It will be possible to switch to option **C** later, when it will appear useful. At that time, we may have more information about what would be the best strategy. I'm a big fan of Joshua Bloch's golden rule of API design _"in case of doubt, leave it out"_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
