gnodet-bot commented on code in PR #618: URL: https://github.com/apache/maven-jar-plugin/pull/618#discussion_r4259645078
########## src/site/markdown/examples/manifest-customization.md.vm: ########## @@ -29,18 +29,16 @@ under the License. The Default Manifest -------------------- -The documentation for [Maven Archiver](/shared/maven-archiver/examples/manifest.html) describes the default contents of the manifest. - -Since version 2.1, the Maven JAR Plugin no longer creates the Specification and Implementation details in the manifest by default. -To add them, specify them explicitly in your plugin configuration. -The documentation for [Maven Archiver](/shared/maven-archiver/examples/manifest.html) describes this as well. +The default manifest is built by `ManifestBuilder` based on the `<archive>` configuration. +By default, it includes the `Built-By`, `Created-By`, and `Build-Jdk-Spec` attributes. Review Comment: ⚠️ **Inaccurate default attribute list:** `Built-By` is only emitted when `addBuildEnvironmentEntries` is `true` (field default: `false`). `Build-Jdk-Spec` is also gated behind that flag — `AbstractJarMojo` passes `addBuildEnvironmentEntries` to `setBuildJdkSpecDefaultEntry()`. Only `Created-By` (and `Java-Version` when the compiler target is discoverable from the POM) are present by default. ```suggestion By default, it includes the `Created-By` attribute (and `Java-Version` when the compiler target is discoverable). When `addBuildEnvironmentEntries` is enabled, `Built-By`, `Build-Jdk`, and `Build-Jdk-Spec` are also added. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
