gnodet opened a new pull request, #618:
URL: https://github.com/apache/maven-jar-plugin/pull/618
## Summary
The plugin now uses the JDK `jar` tool to create archives, so
`plexus-archiver` was no longer used to package files. However it (and
`maven-archiver`) were still needed for manifest generation.
This PR inlines the manifest generation directly into the plugin, removing
both dependencies:
- **`ArchiveConfiguration`** replaces `MavenArchiveConfiguration` (with
inner `ManifestConfig` and `ManifestSection`). The `<archive>` plugin parameter
XML structure is preserved.
- **`ManifestBuilder`** replaces `MavenArchiver.getManifest()`:
- Uses `java.util.jar.Manifest` directly (no plexus types)
- Uses `org.apache.maven.api.services.Interpolator` for classpath layout
interpolation (replaces `plexus-interpolation`)
- Inlines `BuildHelper.discoverJavaRelease()` using pure Maven 4 API
(`org.apache.maven.api.model`)
## Dependencies removed
- `org.apache.maven.shared:maven-archiver`
- `org.codehaus.plexus:plexus-archiver`
- `org.codehaus.plexus:plexus-interpolation` (transitive)
## Notes
- All 16 unit tests pass
- The `<archive>` parameter XML schema is identical from the user's
perspective
- `maven-war-plugin` and `maven-source-plugin` still use `maven-archiver`
independently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
