efegokdemir commented on code in PR #183:
URL: https://github.com/apache/maven-shared-jar/pull/183#discussion_r4234756103
##########
src/main/java/org/apache/maven/shared/jar/JarAnalyzer.java:
##########
@@ -89,7 +84,8 @@ public class JarAnalyzer {
private final JarData jarData;
/**
- * Constructor. Opens the JAR file, so should be matched by a call to
{@link #closeQuietly()}.
+ * Constructor. Opens the JAR file, so should be matched by a call to
{@link #close()} or
Review Comment:
Fixed in `72e39bec88a2be9447c97146e1abf393e2fe41fb`: the constructor Javadoc
now explicitly recommends try-with-resources. `git diff --check` passed. I
could not run Maven locally because this environment has no Java runtime; the
previous CI attempt failed during JDK download before tests ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
