desruisseaux commented on PR #618:
URL: https://github.com/apache/maven-jar-plugin/pull/618#issuecomment-6253954947

   > checking all Maven-maintained packaging plugins:
   > 
   > ```
   > ❯ grep maven-archiver */pom.xml
   > maven-acr-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-ear-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-ejb-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-jar-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-jlink-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-rar-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-source-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > maven-war-plugin/pom.xml:      <artifactId>maven-archiver</artifactId>
   > ```
   > 
   > consistency for all these plugins is key (and I'm not considering any 
community plugin that may use maven-archiver too)
   
   Can we be more accurate about which consistency we are talking about? I had 
the feeling that Maven Archiver was a collection of formats, with special cases 
for JAR, special cases for EAR, special cases for WAR, etc. Now that we 
migrated to the JAR tools, the only part of Maven Archiver that was still used 
is adding a few attributes to the `MANIFEST.MF` file. The remaining of Maven 
Archiver became ignored by Maven JAR Plugin. Aren't the `MANIFEST.MF` 
attributes specific to the JAR format? If no, which attributes are expected to 
be shared exactly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to