gnodet commented on PR #618: URL: https://github.com/apache/maven-jar-plugin/pull/618#issuecomment-6253981720
All review feedback has been addressed. Summary of recent changes: **@hboutemy** — The archive configuration documentation you requested has been added. `manifest-customization.md.vm` now includes a full reference for the `<archive>` element (all fields, types, defaults, and descriptions), a note that this configuration is now managed locally and may diverge from the Maven Archiver docs, and classpath layout expression docs. The page also clearly states at the top that the configuration is no longer delegated to the external `maven-archiver` library. **@elharo** — All inline nits have been addressed: variable renames (`m`→`manifest`, `org`→`organization`, `p`→`plugin`, `k`→`normalizedKey`, `c`→`classifier`), constants inlined per request, deprecated `Implementation-Vendor-Id`/`Implementation-Url` dropped. **Copilot findings** — All four medium-severity items addressed: `packageName`/`addExtensions`/`recompressAddedZips` restored, `Build-Tool`/`Build-Os`/`Build-Jdk` format restored, `classpathPrefix` normalization (trailing slash, backslash conversion) restored, and `specificationVersion()` trailing-dot guard improved. CI is green across all matrix configurations. Could @hboutemy and @elharo re-review when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
