olamy commented on PR #493: URL: https://github.com/apache/maven-build-cache-extension/pull/493#issuecomment-6488686443
I have reviewed this and found other problems here. I have created some IT tests for those cases with this PR https://github.com/apache/maven-build-cache-extension/pull/563 you can grab them into your PR. 1. Regression with `restoreOnDiskArtifacts=false` after `clean compile`, running `clean verify -Dmaven.build.cache.restoreOnDiskArtifacts=false` fails in `jar:jar` with "You have to use a classifier to attach supplemental artifacts...". The artifact now points at the file inside the cache. This one passes on master. 2. Wrong classes in builds without `clean` (`CompileOnlyRestoreStaleDownstreamTest`): restored class files keep their old timestamps, so the compiler says "Nothing to compile" for downstream and keeps classes built against another version of upstream. The build passes and the bad output gets cached. 3. #492 still happens with a `test-jar` dependency (`CompileOnlyRestoreTestJarDependencyTest`) or a goal that forks the lifecycle like `dependency:analyze` (`CompileOnlyRestoreForkedLifecycleTest`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
