gnodet commented on PR #13249: URL: https://github.com/apache/maven/pull/13249#issuecomment-6680708751
Thanks for the review @rmannibucau! Responding to the two points from the review summary not covered by the inline replies: **XML format normalization** (compact form everywhere): The current format uses nested tags for some constructs (`<phase>` with attributes, `<extension>` with children) and inline text for others (`<options>`, `<args>`). Both forms are intentional — the structured `<arg>` / `<args>` form is preferred and the inline text is a shorthand. The `<extension>` format follows the existing `extensions.xml` conventions. I am open to normalizing toward compact form throughout if there is consensus, but that would be a cosmetic restructuring that I would prefer to handle as a follow-up to keep this PR focused. **XSD**: The XSD is auto-generated by Modello from `reactor.mdo` (the namespace and schema location are declared in the model: `https://maven.apache.org/xsd/reactor-1.0.0.xsd`). The generated XSD lives in `target/generated-site/resources/xsd/` and would be published as part of the site build. No manual XSD authoring is needed — Modello handles it. If the expectation is to commit a static copy, I can add that, but the standard Maven pattern for `.mdo`-based models is to let Modello generate and publish it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
