gnodet-bot commented on code in PR #13249:
URL: https://github.com/apache/maven/pull/13249#discussion_r4492705746
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java:
##########
@@ -575,6 +629,47 @@ protected List<CoreExtension>
validateCoreExtensionsDescriptorFromFile(
return coreExtensions;
}
+ /**
+ * Converts a {@link org.apache.maven.api.reactor.ReactorExtension} from
{@code reactor.xml} to a
+ * {@link CoreExtension}, resolving the {@code id} shorthand
(groupId:artifactId:version) if present and
+ * validating that coordinates are complete and unambiguous.
+ */
+ static CoreExtension
toCoreExtension(org.apache.maven.api.reactor.ReactorExtension re) {
+ String groupId = re.getGroupId();
+ String artifactId = re.getArtifactId();
+ String version = re.getVersion();
+ String id = re.getId();
+ if (id != null && !id.isEmpty()) {
Review Comment:
💡 **Nit:** The helper `isNullOrEmpty` already exists 15 lines below — use it
here for consistency with line 656.
```suggestion
if (!isNullOrEmpty(id)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
