mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346403489
##########
File path:
metron-analytics/metron-maas-service/src/test/java/org/apache/metron/maas/service/MaasIntegrationTest.java
##########
@@ -234,13 +238,13 @@ public void run() {
}
Thread.sleep(2000);
}
- Assert.assertTrue(passed);
+ assertTrue(passed);
}
{
List<ModelEndpoint> endpoints = discoverer.getEndpoints(new
Model("dummy", "1.0"));
- Assert.assertNotNull(endpoints);
- Assert.assertEquals(1, endpoints.size());
+ assertNotNull(endpoints);
Review comment:
Haven't had a chance to see if you replaced with static imports everywhere,
but I'm a fan. Thanks for this improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
