mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346971932
##########
File path:
metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/StellarTransformationTest.java
##########
@@ -28,39 +28,16 @@
import org.apache.metron.stellar.common.CachingStellarProcessor;
import org.apache.metron.stellar.dsl.Context;
import org.json.simple.JSONObject;
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
-import java.util.Arrays;
-import java.util.Collection;
import java.util.HashMap;
+import java.util.stream.Stream;
-@RunWith(Parameterized.class)
-public class StellarTransformationTest {
- Context context;
- public StellarTransformationTest(Cache<CachingStellarProcessor.Key, Object>
cache) {
- if(cache == null) {
- context = Context.EMPTY_CONTEXT();
- }
- else {
- context = new Context.Builder().with(Context.Capabilities.CACHE, () ->
cache).build();
- }
- }
-
- @Parameterized.Parameters
Review comment:
Won't removing this change the types of validations this suite of tests will
perform?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
