mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r346400874
########## File path: dependencies_with_url.csv ########## @@ -52,6 +52,7 @@ javax.xml.stream:stax-api:jar:1.0-2:compile,COMMON DEVELOPMENT AND DISTRIBUTION jline:jline:jar:0.9.94:compile,BSD,http://jline.sourceforge.net junit:junit:jar:4.12:compile,Eclipse Public License 1.0,http://junit.org junit:junit:jar:4.4:compile,Common Public License Version 1.0,http://junit.org +junit:junit:jar:4.10:compile,Common Public License Version 1.0,http://junit.org Review comment: I was going to ask if we could remove all the junit 4.x references now that we're moving to JUnit 5. Seeing this addition of 4.10, I'm curious what's happening here. Does 5 still depend on 4? Or is this not a complete transition to 5? If there's anything leftover depending on 4, it would be good to get a list for house cleaning. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
