nickwallen commented on a change in pull request #1568: METRON-2324:
verify_licenses.sh and list_dependencies.sh don't properly handle maven failures
URL: https://github.com/apache/metron/pull/1568#discussion_r354855217
##########
File path: .travis.yml
##########
@@ -60,6 +60,7 @@ matrix:
- name: Verify Licenses
script:
+ - time mvn install -T 2C -q -DskipTests=true -Dmaven.javadoc.skip=true
-B -V -Dskip.npm
Review comment:
(3)
> In practice, I don't know that anyone actually runs the script without
already having relevant builds ...
If I get a Travis failure on the license verification, then switch to my
local machine to figure out why, I would just run the script. This could put
me in a situation where the outputs are different and it would be confusing.
It seems to have caused you some headaches in the JUnit 5 upgrade, so I
think we should do more to avoid causing someone else the same headaches in the
future.
> We could split the difference and add a flag to run the build to the
script and kick out a warning if it's not done or something?
If you want to add a flag to the script, that works for me. Just calling
`mvn install ... ` from inside the script seems even simpler to me, but I'd be
happy with a flag and check to avoid the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
