nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354871862
########## File path: .travis.yml ########## @@ -60,6 +60,7 @@ matrix: - name: Verify Licenses script: + - time mvn install -T 2C -q -DskipTests=true -Dmaven.javadoc.skip=true -B -V -Dskip.npm Review comment: > Having said that, I'd actually make the opposite argument. If the point is to avoid npm, we should be using the built-in skip.npm and building all the modules, rather than making exceptions. I am just interested in consistency. Using one approach is just the most obvious thing to do here and leaves less open questions for future maintainers. If you can update the PR to use one approach or the other, I'd be a happy camper. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services