nickwallen commented on a change in pull request #1568: METRON-2324: 
verify_licenses.sh and list_dependencies.sh don't properly handle maven failures
URL: https://github.com/apache/metron/pull/1568#discussion_r354855951
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -60,6 +60,7 @@ matrix:
 
     - name: Verify Licenses
       script:
+        - time mvn install -T 2C -q -DskipTests=true -Dmaven.javadoc.skip=true 
-B -V -Dskip.npm
 
 Review comment:
   (1) 
   
   > Just skips the UI portion of the build. it's already built-in. 
   
   Is this functionally different than `-pl '!:metron-config,!:metron-alerts'` 
that is already used elsewhere in our `.travis.yml`?  
   
   If it is functionally the same, then why not just use the existing approach?
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to