adam-markovics commented on a change in pull request #1161: URL: https://github.com/apache/nifi-minifi-cpp/pull/1161#discussion_r690422373
########## File path: extensions/pcap/CMakeLists.txt ########## @@ -19,11 +19,21 @@ find_package(PCAP REQUIRED) +include(FetchContent) + +FetchContent_Declare(pcapplusplus + URL https://github.com/seladb/PcapPlusPlus/archive/refs/tags/v21.05.tar.gz + URL_HASH SHA256=f7bc2caea72544f42e3547c8acf65fca07ddd4cd45f7be2f5132dd1826ea27bb + ) +if (NOT pcapplusplus_POPULATED) Review comment: FetchContent_GetProperties is missing, `pcapplusplus_POPULATED` is unset, we will always go into this `if`. Could FetchContent_MakeAvailable be enough? https://cmake.org/cmake/help/latest/module/FetchContent.html#populating-the-content ########## File path: extensions/pcap/CMakeLists.txt ########## @@ -19,11 +19,21 @@ find_package(PCAP REQUIRED) +include(FetchContent) + +FetchContent_Declare(pcapplusplus + URL https://github.com/seladb/PcapPlusPlus/archive/refs/tags/v21.05.tar.gz Review comment: Why not use GIT_REPOSITORY and GIT_TAG instead of URL and URL_HASH? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
