szaszm commented on pull request #1161: URL: https://github.com/apache/nifi-minifi-cpp/pull/1161#issuecomment-901015526
> With this update we will lose one patch > [0a85355#diff-d5fb6148c112e5a8e71e9461291971936c683b6217ecc35b2af427dfd68edf68R94-R95](https://github.com/apache/nifi-minifi-cpp/commit/0a85355f8208f7cabd81e5fee9a72075289a1b28#diff-d5fb6148c112e5a8e71e9461291971936c683b6217ecc35b2af427dfd68edf68R94-R95) > volatile keyword was added to PcapLiveDevice::m_StatsThreadStarted and PcapLiveDevice::m_StopThread for some reason during SUSE and SLES12 release support. > Unfortunetly I am not sure why this was added, or that it is still needed or not. Looking at the change, I'm pretty sure whatever the intention was, it didn't achieve it, so I think it's safe to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
