szaszm commented on a change in pull request #1161: URL: https://github.com/apache/nifi-minifi-cpp/pull/1161#discussion_r691121818
########## File path: extensions/pcap/CMakeLists.txt ########## @@ -19,11 +19,19 @@ find_package(PCAP REQUIRED) +include(FetchContent) + +FetchContent_Declare(pcapplusplus + URL https://github.com/seladb/PcapPlusPlus/archive/refs/tags/v21.05.tar.gz + URL_HASH SHA256=f7bc2caea72544f42e3547c8acf65fca07ddd4cd45f7be2f5132dd1826ea27bb + ) +FetchContent_MakeAvailable(pcapplusplus) + include(${CMAKE_SOURCE_DIR}/extensions/ExtensionHeader.txt) include_directories(/usr/include/netinet) Review comment: Could you convert the `include_directories` calls to target-oriented equivalents? If you don't mind fixing this old issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
