szaszm commented on a change in pull request #1198:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1198#discussion_r728229401
##########
File path: extensions/sensors/SensorBase.h
##########
@@ -74,8 +73,8 @@ class SensorBase : public core::Processor {
};
protected:
- RTIMUSettings settings;
- std::unique_ptr<RTIMU> imu;
+ std::unique_ptr<RTIMUSettings> settings_;
Review comment:
Consider using `std::optional` for late initialization. It avoids one
indirection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
