szaszm commented on a change in pull request #1230:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1230#discussion_r779301904
##########
File path: cmake/BundledOpenCV.cmake
##########
@@ -138,10 +134,15 @@ function(use_bundled_opencv SOURCE_DIR BINARY_DIR)
set_target_properties(OPENCV::libpng PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libpng${THIRDPARTY_SUFFIX}")
add_dependencies(OPENCV::libpng opencv-external)
+ add_library(OPENCV::libopenjp2 STATIC IMPORTED)
+ set_target_properties(OPENCV::libopenjp2 PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libopenjp2${THIRDPARTY_SUFFIX}")
Review comment:
I got this error:
```
make[2]: *** No rule to make target
'thirdparty/opencv-install/lib64/opencv4/3rdparty/liblibopenjp2.a', needed by
'bin/libminifi-opencv.so'. Stop.
make[1]: *** [CMakeFiles/Makefile2:6131:
extensions/opencv/CMakeFiles/minifi-opencv.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
```
Removing the "lib" part after `${PREFIX}` didn't help, but it changed the
missing target from "liblibopenjp2.a" to "libopenjp2.a". I don't know what's
the problem.
This was a clean build, only reusing FetchContent dependencies, but this
uses ExternalProject, so I think it shouldn't be an issue. Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
