lordgamez commented on a change in pull request #1230:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1230#discussion_r779504770
##########
File path: cmake/BundledOpenCV.cmake
##########
@@ -138,10 +134,15 @@ function(use_bundled_opencv SOURCE_DIR BINARY_DIR)
set_target_properties(OPENCV::libpng PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libpng${THIRDPARTY_SUFFIX}")
add_dependencies(OPENCV::libpng opencv-external)
+ add_library(OPENCV::libopenjp2 STATIC IMPORTED)
+ set_target_properties(OPENCV::libopenjp2 PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libopenjp2${THIRDPARTY_SUFFIX}")
Review comment:
That looks to be right, maybe it is a ordering issue with the
compilation of the targets when compiling them on multiple threads. Could you
check if the issue persists if the
`add_dependencies(OPENCV::libopencv-imgcodecs opencv-external)` line is
expanded with the linked targets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
