szaszm commented on a change in pull request #1230:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1230#discussion_r779612539
##########
File path: cmake/BundledOpenCV.cmake
##########
@@ -138,10 +134,15 @@ function(use_bundled_opencv SOURCE_DIR BINARY_DIR)
set_target_properties(OPENCV::libpng PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libpng${THIRDPARTY_SUFFIX}")
add_dependencies(OPENCV::libpng opencv-external)
+ add_library(OPENCV::libopenjp2 STATIC IMPORTED)
+ set_target_properties(OPENCV::libopenjp2 PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libopenjp2${THIRDPARTY_SUFFIX}")
Review comment:
Do we actually need this new dependency though? Why did you add openjp2?
I originally assumed it's just a new upstream dependency, but it seems to be
just another alternative jpeg codec library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
