szaszm commented on a change in pull request #1230:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1230#discussion_r779638904
##########
File path: cmake/BundledOpenCV.cmake
##########
@@ -138,10 +134,15 @@ function(use_bundled_opencv SOURCE_DIR BINARY_DIR)
set_target_properties(OPENCV::libpng PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libpng${THIRDPARTY_SUFFIX}")
add_dependencies(OPENCV::libpng opencv-external)
+ add_library(OPENCV::libopenjp2 STATIC IMPORTED)
+ set_target_properties(OPENCV::libopenjp2 PROPERTIES IMPORTED_LOCATION
"${OPENCV_BYPRODUCT_DIR}/${CMAKE_INSTALL_LIBDIR}/${THIRDPARTY_DIR}${PREFIX}libopenjp2${THIRDPARTY_SUFFIX}")
Review comment:
Summary (for the record, we continued in PM):
OpenCV changed their JPEG2000 codec from Jasper to OpenJPEG. We didn't have
Jasper enabled previously, but to disable the new codec, we need to use a new
option: `-DWITH_OPENJPEG=OFF`. This one defaults to ON, while the corresponding
`-DBUILD_OPENJPEG` option defaulted to OFF, at least on my machine. Either
including the openjp2 target (this is the openjpeg library name) or disabling
`WITH_OPENJPEG` makes opencv_imgcodecs correctly link to our opencv extension.
We decided not to add JPEG2000 support for now and disable the new codec,
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
